Adds npm lint command and updates lint options #467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thechenky
commented
Jun 13, 2019
kevinajian
approved these changes
Jun 13, 2019
bkendall
reviewed
Jun 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does not add new functionality
These changes to the linter are setting up for adding the lint command into our tests just like in the CLI - the options are consistent with what we have in firebase-tools. But before we can add this into our test flow we need to fix all the linter issues that currently being thrown, which I will be doing in following PRs.
Code sample
npm run lintwill now print the warnings (not error yet, we can put that in later). There are a lot of them right now.